Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use CMake to build os-autoinst #3283

Merged
merged 1 commit into from
Aug 4, 2020
Merged

Conversation

Martchus
Copy link
Contributor

I suppose this is actually necessary because os-autoinst-devel will now only pull the dependencies for the CMake build.

@Martchus Martchus force-pushed the cmake branch 2 times, most recently from f4a0aa5 to bbbe7e2 Compare July 30, 2020 07:14
@Martchus
Copy link
Contributor Author

The tests fail because cmake is not found. That is because it is still using the old Docker image. I needed to submit the Docker change first without adapting the CI job. That's annoying because it means merging the Docker change blindly.

I could also add another PR which installs os-autoinst-devel only in addition to the current dependency list. Then I would change the CI job and afterwards reduce the dependencies in the Dockerfile. The last step would still be risky but at least no force-merging would be required.

.circleci/build_autoinst.sh Outdated Show resolved Hide resolved
docker/devel:openQA:ci/base/Dockerfile Outdated Show resolved Hide resolved
tools/run-tests-within-container Outdated Show resolved Hide resolved
@Martchus Martchus force-pushed the cmake branch 3 times, most recently from db67d5d to 69b13c7 Compare July 30, 2020 14:36
and remove dependencies for autotools-based build from Dockerfile
@codecov
Copy link

codecov bot commented Aug 4, 2020

Codecov Report

Merging #3283 into master will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3283   +/-   ##
=======================================
  Coverage   91.49%   91.50%           
=======================================
  Files         215      215           
  Lines       13062    13062           
=======================================
+ Hits        11951    11952    +1     
+ Misses       1111     1110    -1     
Impacted Files Coverage Δ
lib/OpenQA/WebAPI/Plugin/Helpers.pm 95.91% <0.00%> (+0.40%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d88f852...7c9ea5b. Read the comment docs.

@Martchus
Copy link
Contributor Author

Martchus commented Aug 4, 2020

It works after rebasing against the latest ci-packages.txt. The CI log for caching shows that CMake is used and the fullstack tests are still passing.

@Martchus Martchus merged commit 7b5f194 into os-autoinst:master Aug 4, 2020
@Martchus Martchus deleted the cmake branch August 4, 2020 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants