Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "last good" link introduced in 8fc2dc99a #3284

Merged
merged 1 commit into from
Jul 24, 2020

Conversation

okurz
Copy link
Member

@okurz okurz commented Jul 24, 2020

Copy link
Contributor

@Martchus Martchus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Note that using the url_for helper would likely be the best (or at least designated) way to make this.

@codecov
Copy link

codecov bot commented Jul 24, 2020

Codecov Report

Merging #3284 into master will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3284      +/-   ##
==========================================
- Coverage   91.51%   91.50%   -0.01%     
==========================================
  Files         215      215              
  Lines       13064    13064              
==========================================
- Hits        11955    11954       -1     
- Misses       1109     1110       +1     
Impacted Files Coverage Δ
lib/OpenQA/Schema/Result/Jobs.pm 97.68% <ø> (ø)
lib/OpenQA/WebSockets.pm 85.71% <0.00%> (-3.18%) ⬇️
lib/OpenQA/WebAPI/Plugin/Helpers.pm 95.91% <0.00%> (+0.40%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 943ad13...7c886cf. Read the comment docs.

@okurz
Copy link
Member Author

okurz commented Jul 24, 2020

I was thinking of url_for as well, maybe as a follow-up

@okurz okurz merged commit c3016a8 into os-autoinst:master Jul 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants