Improve error messages when cloning a job #3312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Martchus
commented
Aug 14, 2020
Martchus
commented
- Return expected exceptions to the user as error messages
- Avoid returning random exceptions like database errors
- Improve logging
- See https://progress.opensuse.org/issues/69871
In fact we don't want to duplicate any jobs which are still scheduled so simply check for this state. (Assigned jobs might have just been started by the worker and are therefore treated like running jobs.)
kalikiana
approved these changes
Aug 14, 2020
* Return expected exceptions to the user as error messages * Avoid returning random exceptions like database errors * Improve logging * See https://progress.opensuse.org/issues/69871
Codecov Report
@@ Coverage Diff @@
## master #3312 +/- ##
==========================================
- Coverage 91.62% 91.60% -0.02%
==========================================
Files 215 215
Lines 13086 13085 -1
==========================================
- Hits 11990 11987 -3
- Misses 1096 1098 +2
Continue to review full report at Codecov.
|
Amrysliu
approved these changes
Aug 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.