Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Prevent too early circleci timeout on no output #3407

Merged
merged 1 commit into from
Sep 19, 2020

Conversation

okurz
Copy link
Member

@okurz okurz commented Sep 18, 2020

We have some long running tests and especially with internal retrying
aborting after 10m prevents access to helpful details what actually went
wrong. This commit increases the timeout when circleci aborts a job from
10m without output to 30m to help in these cases. Still our goal should
be for each individual test to finish much faster of course.

Related progress issue: https://progress.opensuse.org/issues/66664

We have some long running tests and especially with internal retrying
aborting after 10m prevents access to helpful details what actually went
wrong. This commit increases the timeout when circleci aborts a job from
10m without output to 30m to help in these cases. Still our goal should
be for each individual test to finish much faster of course.

See
https://support.circleci.com/hc/en-us/articles/360007188574-Build-has-hit-timeout-limit
for reference.

Related progress issue: https://progress.opensuse.org/issues/66664
@codecov
Copy link

codecov bot commented Sep 18, 2020

Codecov Report

Merging #3407 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3407      +/-   ##
==========================================
- Coverage   95.49%   95.48%   -0.02%     
==========================================
  Files         362      362              
  Lines       31377    31377              
==========================================
- Hits        29963    29959       -4     
- Misses       1414     1418       +4     
Impacted Files Coverage Δ
t/34-developer_mode-unit.t 98.72% <0.00%> (-0.77%) ⬇️
t/lib/OpenQA/SeleniumTest.pm 88.04% <0.00%> (-0.55%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update edf2c82...3bfc77c. Read the comment docs.

@okurz okurz merged commit 174d32c into os-autoinst:master Sep 19, 2020
@okurz okurz deleted the fix/no_output_in_circleci branch September 19, 2020 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants