Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure a timeout for javascript in webdriver #3430

Merged
merged 1 commit into from Sep 29, 2020

Conversation

kalikiana
Copy link
Member

By default scripts can literally take forever to execute.

See: https://progress.opensuse.org/issues/71554

t/lib/OpenQA/SeleniumTest.pm Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Sep 28, 2020

Codecov Report

Merging #3430 into master will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3430      +/-   ##
==========================================
- Coverage   95.58%   95.57%   -0.01%     
==========================================
  Files         363      363              
  Lines       31552    31553       +1     
==========================================
  Hits        30158    30158              
- Misses       1394     1395       +1     
Impacted Files Coverage Δ
t/lib/OpenQA/SeleniumTest.pm 89.61% <ø> (+0.05%) ⬆️
t/lib/OpenQA/Test/FullstackUtils.pm 79.24% <0.00%> (-15.10%) ⬇️
lib/OpenQA/WebSockets.pm 85.71% <0.00%> (-3.18%) ⬇️
t/05-scheduler-full.t 97.94% <0.00%> (+0.51%) ⬆️
t/34-developer_mode-unit.t 99.48% <0.00%> (+0.76%) ⬆️
t/lib/OpenQA/Test/Utils.pm 68.94% <0.00%> (+3.70%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e4a962c...2fb0ae8. Read the comment docs.

@kalikiana kalikiana marked this pull request as ready for review September 29, 2020 06:36
t/lib/OpenQA/SeleniumTest.pm Outdated Show resolved Hide resolved
By default scripts can literally take forever to execute.
@okurz okurz merged commit 3d36bee into os-autoinst:master Sep 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants