Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete obsolete old preview link redirection #3466

Closed
wants to merge 1 commit into from

Conversation

okurz
Copy link
Member

@okurz okurz commented Oct 13, 2020

The redirection based on the request header type should be considered
obsolete after enough time. Also it is hard to understand why a certain
URL is redirecting in one case and behaves different when called with a
different request header.

Related progress issue: https://progress.opensuse.org/issues/72292

The redirection based on the request header type should be considered
obsolete after enough time. Also it is hard to understand why a certain
URL is redirecting in one case and behaves different when called with a
different request header.

Related progress issue: https://progress.opensuse.org/issues/72292
@okurz okurz marked this pull request as draft October 13, 2020 22:02
@Martchus
Copy link
Contributor

I've been searching for /modules/.*/steps/ and it seems only tests still refer to that URL. So it should be safe to delete as long as there are no more external users.

@okurz
Copy link
Member Author

okurz commented Oct 15, 2020

hm, just found out that we still have "modules" URLs for the "src" and "edit" targets. This feels inconsistent but removing the parent URL route completely does not feel like it would help a lot:
https://github.com/os-autoinst/openQA/blob/master/t/27-errorpages.t#L43

But I don't have a good idea if we can do anything about that. Unless someone has a better idea I would leave everything as is. The redirect depending on the header is confusing but removing the route is IMHO worse.

@okurz okurz closed this Nov 3, 2020
@okurz okurz deleted the enhance/no_step_redirect branch November 3, 2020 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants