Simplify OpenQA::Worker::Job::_stop_step_4_upload with turned around if-condition #3493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Amrysliu
approved these changes
Oct 28, 2020
Martchus
approved these changes
Oct 28, 2020
kraih
reviewed
Oct 30, 2020
okurz
force-pushed
the
enhance/worker_job
branch
from
ea432b0
to
0c1e1e4
Compare
kraih
reviewed
Nov 6, 2020
kraih
approved these changes
Nov 6, 2020
okurz
force-pushed
the
enhance/worker_job
branch
from
0c1e1e4
to
f66c6ee
Compare
Codecov Report
@@ Coverage Diff @@
## master #3493 +/- ##
==========================================
- Coverage 95.61% 95.61% -0.01%
==========================================
Files 366 366
Lines 31749 31745 -4
==========================================
- Hits 30356 30352 -4
Misses 1393 1393
Continue to review full report at Codecov.
|
|
the OBS check failed due to an unrelated problem about chromedriver and some changed dependencies in Factory, probably an incomplete Factory rebuild caused this or something. crossing fingers |
openqabot
pushed a commit
to openqabot/openQA
that referenced
this pull request
Nov 10, 2020
commit c341c41 Merge: 7bfaab8 f66c6ee Author: Oliver Kurz <okurz@suse.de> AuthorDate: Mon Nov 9 21:44:51 2020 +0100 Commit: GitHub <noreply@github.com> CommitDate: Mon Nov 9 21:44:51 2020 +0100 Merge pull request os-autoinst#3493 from okurz/enhance/worker_job
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.