cache service: Do not perform re-indexing within a transaction #3566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Otherwise the re-indexing seems not visible and we run into the die. * I've tested this with a broken SQLite file from o3 worker openqaworker4 and only with this change 'Unable to fix errors… Purging cache directory…' is prevented and instead 'Database integrity check passed' shown. * Note that unlinking the SQLite file (log message 'Purging cache directory…') is actually problematic: https://www.sqlite.org/howtocorrupt.html#_unlinking_or_renaming_a_database_file_while_in_use * See https://progress.opensuse.org/issues/67000
Codecov Report
@@ Coverage Diff @@
## master #3566 +/- ##
==========================================
- Coverage 95.69% 95.69% -0.01%
==========================================
Files 366 366
Lines 31882 31881 -1
==========================================
- Hits 30509 30507 -2
- Misses 1373 1374 +1
Continue to review full report at Codecov.
|
okurz
approved these changes
Nov 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and only with this change 'Unable to fix errors… Purging cache directory…'
is prevented and instead 'Database integrity check passed' shown.
directory…') is actually problematic:
https://www.sqlite.org/howtocorrupt.html#_unlinking_or_renaming_a_database_file_while_in_use