docker: Fix web UI container script in basic execution #3607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Martchus
requested changes
Dec 2, 2020
ilausuch
force-pushed
the
fix_basic_webui_container_execution
branch
from
78a7324
to
8560836
Compare
|
Done. I tested this and all the services are running |
Martchus
requested changes
Dec 2, 2020
okurz
requested changes
Dec 2, 2020
ilausuch
force-pushed
the
fix_basic_webui_container_execution
branch
2 times, most recently
from
6cd164e
to
5069a09
Compare
|
All suggestions done and also I modified the gru() function that is used in the load balance execution mode because of the same reason |
ilausuch
force-pushed
the
fix_basic_webui_container_execution
branch
from
5069a09
to
9c8cda3
Compare
Martchus
approved these changes
Dec 3, 2020
kalikiana
approved these changes
Dec 3, 2020
okurz
requested changes
Dec 3, 2020
|
When amending the commit message anyways: The grammar could be improved as well, e.g. add at least a "." at the end. And I still prefer "web UI" over "webUI". This is not a camel case variable name and the unabbreviated form ("web user interface") would also have the space. |
When web UI is executed in a container executes the script run_openqa.sh if this is executed in the default mode with all components together uses the function all_together_apache(). This function has some errors that avoid the execution of the scheduler, websockets and livehandler because some parameters for the command start_daemon are missing. Additionally the same simplification applied here to the gru daemon is also applied to the function gru() which is used by the load balance execution mode. https://progress.opensuse.org/issues/80534
ilausuch
force-pushed
the
fix_basic_webui_container_execution
branch
from
9c8cda3
to
1314780
Compare
ilausuch
changed the title
|
Done both things. Thanks |
okurz
approved these changes
Dec 7, 2020
Codecov Report
@@ Coverage Diff @@
## master #3607 +/- ##
==========================================
- Coverage 95.68% 95.64% -0.05%
==========================================
Files 367 367
Lines 31859 31859
==========================================
- Hits 30485 30472 -13
- Misses 1374 1387 +13
Continue to review full report at Codecov.
|
openqabot
pushed a commit
to openqabot/openQA
that referenced
this pull request
Dec 8, 2020
commit ab9d59c Merge: 4cd1f43 1314780 Author: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> AuthorDate: Mon Dec 7 19:08:20 2020 +0000 Commit: GitHub <noreply@github.com> CommitDate: Mon Dec 7 19:08:20 2020 +0000 Merge pull request os-autoinst#3607 from ilausuch/fix_basic_webui_container_execution docker: Fix web UI container script in basic execution
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When web UI is executed in a container executes the script run_openqa.sh
if this is executed in the default mode with all components together
uses the function all_together_apache(). This function has some errors
that avoid the execution of the scheduler, websockets and livehandler
because some parameters for the command start_daemon are missing.
Additionally the same simplification applied here to the gru daemon
is also applied to the function gru() which is used by the load balance
execution mode.
progress.opensuse.org/issues/80534