Add service files to restart worker after config changes without interrupting running jobs #3666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3666 +/- ##
==========================================
+ Coverage 96.35% 96.39% +0.04%
==========================================
Files 369 369
Lines 32321 32321
==========================================
+ Hits 31144 31157 +13
+ Misses 1177 1164 -13
Continue to review full report at Codecov.
|
Martchus
force-pushed
the
worker-soft-restart-on-config-change-via-systemd
branch
from
641d2e5
to
5b131df
Compare
Martchus
changed the title
|
This seems to work as expected. |
okurz
requested changes
Jan 28, 2021
Martchus
force-pushed
the
worker-soft-restart-on-config-change-via-systemd
branch
from
5b131df
to
bea2b9a
Compare
okurz
approved these changes
Jan 28, 2021
Martchus
force-pushed
the
worker-soft-restart-on-config-change-via-systemd
branch
from
bea2b9a
to
a1322e2
Compare
…rrupting running jobs * As long as e.g. `openqa-reload-worker-auto-restart@1.path` is running the worker started via the corresponding service unit `openqa-worker-auto-restart@1.service` is restarted as soon as it becomes idle (and immediately if it is already idling) when `/etc/openqa/workers.ini` is edited. * See https://progress.opensuse.org/issues/80910 and https://progress.opensuse.org/issues/80908#note-8
Martchus
force-pushed
the
worker-soft-restart-on-config-change-via-systemd
branch
from
a1322e2
to
33ac2a4
Compare
openqabot
pushed a commit
to openqabot/openQA
that referenced
this pull request
Feb 2, 2021
commit 8efacba Merge: 1998b3c 33ac2a4 Author: Martchus <martchus@gmx.net> AuthorDate: Mon Feb 1 10:25:59 2021 +0100 Commit: GitHub <noreply@github.com> CommitDate: Mon Feb 1 10:25:59 2021 +0100 Merge pull request os-autoinst#3666 from Martchus/worker-soft-restart-on-config-change-via-systemd Add service files to restart worker after config changes without interrupting running jobs
openqa-git-sync
pushed a commit
to os-autoinst/salt-states-openqa
that referenced
this pull request
Apr 19, 2021
This way workers are restarted as soon as possible without interfering currently running jobs when the worker config changes. The restart of the services is triggered by a special systemd unit. The salt configuration merely enables that unit. Hence this change depends on the following upstream change: os-autoinst/openQA#3666 Relevant tickets: * https://progress.opensuse.org/issues/80910 * https://progress.opensuse.org/issues/80908#note-8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
openqa-soft-restart-worker@1.pathis runningthe worker started via the corresponding service unit
openqa-worker-auto-restart@1.serviceis restarted as soon as itbecomes idle (and immediately if it is already idling) when
/etc/openqa/workers.iniis edited.and https://progress.opensuse.org/issues/80908#note-8
We could actually also watch for a packaged file so it would also applyMaybe that's better done on RPM level as suggested in https://progress.opensuse.org/issues/80908#note-8 (point 2.)?to package updates.
OPENQA_WORKER_TERMINATE_AFTER_JOBS_DONE=1in the auto-restart service file.