Fix/improve reloading worker #3716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Receiving SIGHUP is supposed to stop the worker as soon as possible without interrupting ongoing jobs. Sending a 2nd SIGHUP should not make a difference. When the worker receives SIGTERM/SIGINT before or after receiving SIGHUP then the SIGTERM/SIGINT of course still rule over SIGHUP (and the current jobs stopped).
…n process Otherwise e.g. isotovideo receives SIGHUP as well and terminates.
This should be more intuitive than the `systemd kill …` command (which of course still be used). Like in the previous commit, SIGHUP is only sent to the main worker process.
Codecov Report
@@ Coverage Diff @@
## master #3716 +/- ##
=======================================
Coverage 96.38% 96.38%
=======================================
Files 369 369
Lines 32273 32279 +6
=======================================
+ Hits 31105 31111 +6
Misses 1168 1168
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've tested this on openqaworker11 by hot patching its service files and
Worker.pm. I've also tested the globbing withsystemctl reloadused within the spec file. I've also tested the changes to the Makefile. Everything worked as expected.