Mark uncoverage statements in OpenQA::Worker::WebUIConnection #3718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kraih
reviewed
Feb 11, 2021
kraih
reviewed
Feb 11, 2021
Martchus
requested changes
Feb 11, 2021
Unreliable coverage observed in tests for os-autoinst#3713 Related progress issue: https://progress.opensuse.org/issues/55364
Martchus
approved these changes
Feb 11, 2021
kalikiana
approved these changes
Feb 11, 2021
kraih
approved these changes
Feb 11, 2021
|
Anyone has an idea about the codecov related failure: ? |
|
No, the same happens on #3714 and persisted after re-triggering codecov. |
|
Seems to happen for all our PRs now. |
Codecov Report
@@ Coverage Diff @@
## master #3718 +/- ##
==========================================
- Coverage 96.38% 96.38% -0.01%
==========================================
Files 369 369
Lines 32279 32274 -5
==========================================
- Hits 31111 31106 -5
Misses 1168 1168
Continue to review full report at Codecov.
|
openqabot
pushed a commit
to openqabot/openQA
that referenced
this pull request
Feb 15, 2021
commit 525d96f Merge: 86968e7 4c2e8c8 Author: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> AuthorDate: Sun Feb 14 15:55:10 2021 +0000 Commit: GitHub <noreply@github.com> CommitDate: Sun Feb 14 15:55:10 2021 +0000 Merge pull request os-autoinst#3718 from okurz/fix/coverage Mark uncoverage statements in OpenQA::Worker::WebUIConnection
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unreliable coverage observed in tests for
#3713
Related progress issue: https://progress.opensuse.org/issues/55364