Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make host names used by internal clients configurable #3735

Conversation

Martchus
Copy link
Contributor

  • This allows to run the web UI, websocket server and scheduler on
    different hosts (e.g. a load balanced environment) provided the newly
    introduced environment variables are set
  • See https://progress.opensuse.org/issues/88187

Copy link
Member

@okurz okurz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

* This allows to run the web UI, websocket server and scheduler on
  different hosts (e.g. a load balanced environment) provided the newly
  introduced environment variables are set
* See https://progress.opensuse.org/issues/88187
@Martchus Martchus force-pushed the make-addresses-of-internal-clients-configurable branch from 3389bf0 to be15e67 Compare February 17, 2021 16:45
@codecov
Copy link

codecov bot commented Feb 17, 2021

Codecov Report

Merging #3735 (be15e67) into master (91dd770) will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3735      +/-   ##
==========================================
+ Coverage   96.33%   96.37%   +0.04%     
==========================================
  Files         369      369              
  Lines       32304    32319      +15     
==========================================
+ Hits        31120    31148      +28     
+ Misses       1184     1171      -13     
Impacted Files Coverage Δ
lib/OpenQA/Scheduler/Client.pm 100.00% <100.00%> (ø)
lib/OpenQA/UserAgent.pm 100.00% <100.00%> (ø)
lib/OpenQA/WebSockets/Client.pm 100.00% <100.00%> (ø)
t/31-client.t 100.00% <100.00%> (ø)
t/lib/OpenQA/Test/Utils.pm 81.50% <0.00%> (+3.75%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 91dd770...be15e67. Read the comment docs.

@mergify mergify bot merged commit 7e82dbf into os-autoinst:master Feb 17, 2021
@Martchus Martchus deleted the make-addresses-of-internal-clients-configurable branch February 18, 2021 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants