Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docker: Allow docker-compose build images #3773

Merged
merged 3 commits into from
Mar 18, 2021
Merged

docker: Allow docker-compose build images #3773

merged 3 commits into from
Mar 18, 2021

Conversation

ilausuch
Copy link
Contributor

@ilausuch ilausuch commented Mar 9, 2021

Now docker-compose is able to build the images before try to start
the containers

https://progress.opensuse.org/issues/89719

@ilausuch ilausuch force-pushed the 89719_docker-compose_up_fails_on_master branch from f729c42 to e6ed95b Compare March 9, 2021 12:48
kalikiana
kalikiana requested changes Mar 9, 2021
View reviewed changes
Copy link
Member

@kalikiana kalikiana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still wondering: will this PR have CI as discussed before?

@ilausuch
Copy link
Contributor Author

ilausuch commented Mar 9, 2021

Still wondering: will this PR have CI as discussed before?

The CI test in #3758 checks this problem too.

@kalikiana
Copy link
Member

Still wondering: will this PR have CI as discussed before?

The CI test in #3758 checks this problem too.

So how would that get merged, though?

@ilausuch
Copy link
Contributor Author

ilausuch commented Mar 9, 2021 •
edited
Loading

Still wondering: will this PR have CI as discussed before?

The CI test in #3758 checks this problem too.

So how would that get merged, though?

But this Test is not going to work without this, and this cannot be checked without the test... then, what is the best solution?

@kalikiana

This comment has been minimized.

Sign in to view
@kalikiana kalikiana mentioned this pull request Mar 9, 2021
Closed
okurz
okurz requested changes Mar 9, 2021
View reviewed changes
Makefile Outdated Show resolved Hide resolved
@ilausuch ilausuch force-pushed the 89719_docker-compose_up_fails_on_master branch from 3a19c67 to bd204e3 Compare March 9, 2021 15:37
kalikiana
kalikiana approved these changes Mar 9, 2021
View reviewed changes
Copy link
Member

@kalikiana kalikiana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume this should be good, provided CI passes. Although I fear only @ilausuch will be able to confirm GHA runs until this hits master and I've not found a way to fix that.

@ilausuch

This comment has been minimized.

Sign in to view
@kalikiana

This comment has been minimized.

Sign in to view
okurz
okurz requested changes Mar 9, 2021
View reviewed changes
Makefile Outdated Show resolved Hide resolved
@ilausuch ilausuch force-pushed the 89719_docker-compose_up_fails_on_master branch from bd204e3 to 54bfac3 Compare March 11, 2021 08:32
@okurz

This comment has been minimized.

Sign in to view
@ilausuch ilausuch force-pushed the 89719_docker-compose_up_fails_on_master branch 2 times, most recently from cd239d0 to e8672bc Compare March 12, 2021 08:56
okurz
okurz requested changes Mar 12, 2021
View reviewed changes
Makefile Outdated Show resolved Hide resolved
@ilausuch ilausuch force-pushed the 89719_docker-compose_up_fails_on_master branch from e8672bc to a9b5788 Compare March 15, 2021 11:08
okurz
okurz reviewed Mar 15, 2021
View reviewed changes
Makefile Show resolved Hide resolved
okurz
okurz requested changes Mar 16, 2021
View reviewed changes
Makefile Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
@ilausuch

This comment has been minimized.

Sign in to view
@ilausuch ilausuch force-pushed the 89719_docker-compose_up_fails_on_master branch from a9b5788 to 0348d76 Compare March 16, 2021 10:42
okurz
okurz approved these changes Mar 16, 2021
View reviewed changes
Copy link
Member

@okurz okurz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, sorry about your "default" comment. I thought I had removed that before posting. Of course it's there already

@kalikiana kalikiana mentioned this pull request Mar 16, 2021
Closed
@okurz
Copy link
Member

okurz commented Mar 16, 2021

have you seen the error on OBS?:

[ 1378s] for i in container/webui/docker-compose.yaml; do sudo docker-compose up -d -f $i;  done
[ 1378s] /bin/sh: line 1: sudo: command not found

@ilausuch
Copy link
Contributor Author

ilausuch commented Mar 16, 2021 •
edited
Loading

The purpose of the new commit is only to test the OBS problem removing the sudo command. It works will be stashed

@okurz
Copy link
Member

okurz commented Mar 17, 2021

https://github.com/os-autoinst/openQA/pull/3796/checks?check_run_id=2132109256 shows a failure correctly detected but now https://github.com/os-autoinst/openQA/pull/3773/checks?check_run_id=2132326640#step:3:41 fails as well. Is this what you expected?

@ilausuch ilausuch force-pushed the 89719_docker-compose_up_fails_on_master branch from d0b6c23 to 1235f97 Compare March 18, 2021 08:48
@ilausuch
Copy link
Contributor Author

#3796 (checks) shows a failure correctly detected but now #3773 (checks) fails as well. Is this what you expected?

I didn't expected a failure, in my dev env works, I am adding more logs to see what is the problem

@ilausuch ilausuch force-pushed the 89719_docker-compose_up_fails_on_master branch 5 times, most recently from 802e7a0 to 97fd4b5 Compare March 18, 2021 10:03
okurz
okurz requested changes Mar 18, 2021
View reviewed changes
tools/test_containers_compose Outdated Show resolved Hide resolved
@ilausuch ilausuch force-pushed the 89719_docker-compose_up_fails_on_master branch 5 times, most recently from 27088fe to 63c0fc8 Compare March 18, 2021 11:14
@ilausuch
Copy link
Contributor Author

The test is good now, this is ready for review. thanks

@ilausuch
Copy link
Contributor Author

No, there is a problem confirmed by #3796

ilausuch and others added 2 commits March 18, 2021 13:17
@ilausuch
CI: Add compose tests via GitHub workflow
7155d5b 
Testing out a simple GHA to test the docker-compose.yml for the webui using isbang/compose-action.

Related to os-autoinst#3755
@okurz @ilausuch
dist: Exclude less relevant container tests from packaging tests
44ade25
@ilausuch ilausuch force-pushed the 89719_docker-compose_up_fails_on_master branch from 63c0fc8 to 44ade25 Compare March 18, 2021 12:17
@ilausuch
Copy link
Contributor Author

ilausuch commented Mar 18, 2021 •
edited
Loading

Ok, solved, please review.
You can see in this PR #3796 a case where some of the containers fail and how the test check this case

@okurz
Copy link
Member

okurz commented Mar 18, 2021

In detail, https://github.com/os-autoinst/openQA/pull/3796/checks?check_run_id=2139502104 shows how it's correctly handled in case of test failures. Looks good!

@ilausuch ilausuch mentioned this pull request Mar 18, 2021
Closed
@okurz okurz merged commit 6ccbaed into os-autoinst:master Mar 18, 2021
@ilausuch ilausuch mentioned this pull request Mar 18, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@perlpunk perlpunk perlpunk left review comments

@kalikiana kalikiana kalikiana approved these changes

@okurz okurz okurz approved these changes

@Martchus Martchus Martchus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ilausuch @kalikiana @okurz @perlpunk @Martchus