t: Bump timeout for ui/26-jobs_restart.t #4020
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Martchus
approved these changes
Jul 8, 2021
Since recently same like other test files also t/ui/26-jobs_restart.t runs into timeouts both in CI as well as locally. Before changes locally `count_fail_ratio prove -l t/ui/26-jobs_restart.t` using https://github.com/okurz/scripts/tree/master/count_fail_ratio ``` t/ui/26-jobs_restart.t .. 4/? Bailout called. Further testing stopped: findElement: Server returned error message Label not found for "last T2_SUBTEST_WRAPPER" at /usr/lib/perl5/vendor_perl/5.26.1/Test2/Hub/Subtest.pm line 67. at /home/okurz/local/os-autoinst/openQA/t/ui/../lib/OpenQA/SeleniumTest.pm:95 FAILED--Further testing stopped: findElement: Server returned error message Label not found for "last T2_SUBTEST_WRAPPER" at /usr/lib/perl5/vendor_perl/5.26.1/Test2/Hub/Subtest.pm line 67. at /home/okurz/local/os-autoinst/openQA/t/ui/../lib/OpenQA/SeleniumTest.pm:95 … count_fail_ratio: Run: 3. Fails: 3. Fail ratio 100% ``` Bumping timeout from 10s to 30s: ``` … t/ui/26-jobs_restart.t .. ok All tests successful. Files=1, Tests=10, 17 wallclock secs ( 0.12 usr 0.01 sys + 6.61 cusr 0.57 csys = 7.31 CPU) Result: PASS count_fail_ratio: Run: 5. Fails: 0. Fail ratio 0% ``` Crosscheck on an older commit state of openQA, 80f3d69 from 2021-06-11 reproduces the timeout problems so our codebase did not recently introduce such problems. Reproduced again on 627798b from 2021-03-05 the last time when I was working on the same test file myself: ``` count_fail_ratio: Run: 4. Fails: 4. Fail ratio 100% ``` so it's slower on CI and on other people's computers as well as mine (Leap 15.2, not quite up-to-date right now). So most likely hypothesis (not entirely serious) is that the climate change caused this. Related progress issue: https://progress.opensuse.org/issues/95024
ilausuch
approved these changes
Jul 8, 2021
Codecov Report
@@ Coverage Diff @@
## master #4020 +/- ##
==========================================
+ Coverage 93.34% 96.95% +3.61%
==========================================
Files 189 370 +181
Lines 11928 33033 +21105
==========================================
+ Hits 11134 32028 +20894
- Misses 794 1005 +211
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since recently same like other test files also t/ui/26-jobs_restart.t runs into
timeouts both in CI as well as locally.
Before changes locally
count_fail_ratio prove -l t/ui/26-jobs_restart.tusing
https://github.com/okurz/scripts/tree/master/count_fail_ratio
Bumping timeout from 10s to 20s:
Crosscheck on an older commit state of openQA, 80f3d69 from 2021-06-11
reproduces the timeout problems so our codebase did not recently introduce such
problems. Reproduced again on 627798b from 2021-03-05 the last time when I
was working on the same test file myself:
so it's slower on CI and on other people's computers as well as mine (Leap
15.2, not quite up-to-date right now). So most likely hypothesis (not entirely
serious) is that the climate change caused this.
Related progress issue: https://progress.opensuse.org/issues/95024