Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix stability of check for scroll-up button in t/ui/14-dashboard.t #4090

Merged
merged 1 commit into from
Jul 30, 2021

Conversation

Martchus
Copy link
Contributor

See https://progress.opensuse.org/issues/95839


Since #4079 is already at 162 of 200 retries (https://app.circleci.com/pipelines/github/os-autoinst/openQA/7226/workflows/a03ad42e-7967-4447-8698-9aa3b930a7c4/jobs/68213) and locally 200 of 200 runs have already passed I'm preparing this PR.

@Martchus
Copy link
Contributor Author

All 200 tries on #4079 have passed.

@codecov
Copy link

codecov bot commented Jul 30, 2021

Codecov Report

Merging #4090 (8362429) into master (357fc84) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4090      +/-   ##
==========================================
- Coverage   97.62%   97.62%   -0.01%     
==========================================
  Files         371      371              
  Lines       33156    33154       -2     
==========================================
- Hits        32369    32367       -2     
  Misses        787      787              
Impacted Files Coverage Δ
t/ui/14-dashboard.t 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 357fc84...8362429. Read the comment docs.

@okurz
Copy link
Member

okurz commented Jul 30, 2021

OBS checks fail due to https://progress.opensuse.org/issues/96317 , unrelated problem.

@okurz okurz merged commit 6d1449a into os-autoinst:master Jul 30, 2021
@Martchus Martchus deleted the stability-fix branch July 30, 2021 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants