Improve worker's exception handling and related test #4119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Turn `try` into `eval` so the contained `return` actually returns from
the enclosing `sub`
* No longer log `Another error occurred…` when that's not actually the
case
* No longer stop the worker immediately after the first exception
* Log error message from the `eval` block
* Improve tests
* Check whether the event loop is actually stopped in a controlled way
* Check whether all error messages are logged
* Check whether relevant functions are called exactly as many times as
expected
* See https://progress.opensuse.org/issues/96710
Codecov Report
@@ Coverage Diff @@
## master #4119 +/- ##
=======================================
Coverage 97.79% 97.79%
=======================================
Files 371 371
Lines 33145 33161 +16
=======================================
+ Hits 32415 32431 +16
Misses 730 730
Continue to review full report at Codecov.
|
kalikiana
approved these changes
Aug 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tryintoevalso the containedreturnactually returns fromthe enclosing
subAnother error occurred…when that's not actually thecase
evalblockexpected