fix issue #6394: capture git stderr/stdout #414
Conversation
|
you don't seriously need another non-core perl module to catch stderr |
|
This module is already used by os-autoinst backends and does the job nicely. |
|
I don't really care, but this sounds like a hundred times too complex |
|
let us know when you tested it |
|
I suggest you move these 4 lines you added 3 times into a wrapper function in Utils.pm. This way we can replace the solution later if we feel like it |
|
and this way you should be able to write a test case for that util function easily - btw, the git errors shouldn't be ->debug but ->error IMO |
asdil12
force-pushed
the
git_output
branch
5 times, most recently
from
8103b1e
to
35d611a
Compare
|
Done. The test https://github.com/asdil12/openQA/blob/35d611a744781f4a028a9e803d7716947e8d5681/t/16-utils-runcmd.t runs successfully. |
| @@ -0,0 +1,30 @@ | |||
| #!/usr/bin/env perl -w | |||
|
|
|||
| # Copyright (C) 2014 SUSE Linux Products GmbH | |||
There was a problem hiding this comment.
Please use correct copyright, which happen to be
Copyright (C) 2015 SUSE LLC
|
Added correct copyright. |
| @@ -32,6 +32,7 @@ FindBin | |||
| Getopt::Long | |||
| IO::Socket::INET6 | |||
| IO::Socket::SSL | |||
| IPC::Run::Debug | |||
There was a problem hiding this comment.
IPC::Run::Debug? Why not IPC::Run?
There was a problem hiding this comment.
os-autoinst has IPC::Run::Debug in it's DEPENDENCIES.txt so I wanted to make sure that I use the same RPM.
But I guess the rpm should also provide IPC::Run - do you want me to change it?
There was a problem hiding this comment.
Ah, didn't notice that. Anyway I think, requiring ::Debug variant and counting on that it will pull the base is not quite correct. (And on openSUSE IPC::Run::* is provided by the same package)
Adds new dependency: perl(IPC::Run)
|
changed dependency to IPC::Run |
fix issue #6394: capture git stderr/stdout
Adds new dependency: perl(IPC::Run::Debug)
This patch is not tested, yet.