New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the needle dir when worker enables cache service #4245
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please put more details in the git commit message details (not just the reference to the ticket). And there is a typo s/diretory/directory/
b008d85
to
b44dde6
Compare
Thanks. Added more details in commit message. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/diretory/directory/
I did not understand the sentence "This is because we didn't receive the cache directory when count needle_dir." . What do you mean by "count"? Can you rephrase?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, we should definitely pass through all the parameters. Maybe it makes also sense to just write it as:
sub needledir { productdir(@_) . '/needles' }
And I also don't understand the wording in the commit message. Maybe you don't need to go into that much detail anyways.
b44dde6
to
1751317
Compare
I simplified the commit message. Hope it would be clear. :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
commit message is fine. As you try to fix an actual issue, can you add a test?
There are three parameters in productdir(), but now function needledir() pass two. The last one `$rootfortests` is used to store the CACHE directory when worker enables cache service. So we should pass all parameters. Relate ticket: https://progress.opensuse.org/issues/99378
1751317
to
ea899e0
Compare
Added |
Seems like this wasn't merged automatically due to missing codecov report |
Relate ticket: https://progress.opensuse.org/issues/99378