Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent useless downloads of uefi-vars assets #4261

Merged
merged 5 commits into from
Oct 6, 2021
Merged

Prevent useless downloads of uefi-vars assets #4261

merged 5 commits into from
Oct 6, 2021

Commits on Oct 5, 2021

  1. Extend tests for asset download in openqa-clone-job script 

    * Test skipping asset downloads if the (grand) parent is cloned anyways
* Test skipping download of uefi-vars assets
* Test doing asset downloads if skipping download of dependencies
* Test doing download of uefi-vars assets when a parent job is expected
  to generate one (has the `PUBLISH_PFLASH_VARS` setting)
    @Martchus
    Martchus committed Oct 5, 2021
    Configuration menu
    Copy the full SHA
    365613c View commit details
    Browse the repository at this point in the history

  2. Prevent useless downloads of uefi-vars assets 

    * Skip the download similar to `PUBLISH_HDD_1` assets when the generating
  job is cloned as well anyways.
* Skip the download if none of the parent jobs is actually supposed to
  publish the asset (corresponding `PUBLISH_PFLASH_VARS` is absent)
  because then the asset is not needed anyways and likely does not exist
  anyways.
* See https://progress.opensuse.org/issues/99672
  and https://progress.opensuse.org/issues/98388
    @Martchus
    Martchus committed Oct 5, 2021
    Configuration menu
    Copy the full SHA
    e0bb6cb View commit details
    Browse the repository at this point in the history

  3. Consider all parent jobs in openqa-clone-job to skip certain assets 

    So far transitive chained parents are not considered so HDDs would not be
skipped as expected if they would be generated by e.g. a "grand parent"
job.
    @Martchus
    Martchus committed Oct 5, 2021
    Configuration menu
    Copy the full SHA
    0c702bb View commit details
    Browse the repository at this point in the history

  4. Add missing separator in log message of openqa-clone-job script

    @Martchus
    Martchus committed Oct 5, 2021
    Configuration menu
    Copy the full SHA
    cb6d8ee View commit details
    Browse the repository at this point in the history

  5. Extract code from clone_job_download_assets into separate function 

    to prevent the function from becoming too big.
    @Martchus
    Martchus committed Oct 5, 2021
    Configuration menu
    Copy the full SHA
    a5bc31b View commit details
    Browse the repository at this point in the history