fullstack: Make find_status_text wait for the element

[kalikiana]

Fixes the following error:

findElement: no such element: Unable to locate element: {"method":"css
selector","selector":"#info_box .card-body"}`

See: https://progress.opensuse.org/issues/98952

[codecov]

Codecov Report

Merging #4286 (5dfff29) into master (89c0bdd) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head 5dfff29 differs from pull request most recent head 28328e6. Consider uploading reports for the commit 28328e6 to get more accurate results

@@            Coverage Diff             @@
##           master    #4286      +/-   ##
==========================================
- Coverage   97.94%   97.92%   -0.02%     
==========================================
  Files         371      371              
  Lines       33665    33614      -51     
==========================================
- Hits        32972    32917      -55     
- Misses        693      697       +4     

Impacted Files	Coverage Δ
t/full-stack.t	96.62% <100.00%> (-0.35%)	⬇️
t/lib/OpenQA/Test/FullstackUtils.pm	96.80% <100.00%> (-3.20%)	⬇️
lib/OpenQA/Scheduler/Model/Jobs.pm	97.27% <0.00%> (-0.07%)	⬇️
lib/OpenQA/Schema/Result/Jobs.pm	98.49% <0.00%> (-0.01%)	⬇️
t/config.t	100.00% <0.00%> (ø)
t/03-auth.t	100.00% <0.00%> (ø)
t/28-logging.t	100.00% <0.00%> (ø)
t/43-cli-api.t	100.00% <0.00%> (ø)
... and 9 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 89c0bdd...28328e6. Read the comment docs.

[okurz]

Please look into the decreased coverage. All files in t should definitely have 100% statement coverage

[perlpunk]

The flaky coverage for FullstackUtils.pm is handled in
https://progress.opensuse.org/issues/99594

[perlpunk]

The decreased coverage in t/full-stack.t is probably just due to the removal of a subroutine.

[kalikiana]

Maybe #4293 is also an alternative to this one.

[okurz]

The decreased coverage in t/full-stack.t is probably just due to the removal of a subroutine.

But the absolute coverage displayed as not 100% anymore. Do I again misinterpret the codecov numbers?

[mergify]

This pull request is now in conflicts. Could you fix it? 🙏

[perlpunk]

But the absolute coverage displayed as not 100% anymore. Do I again misinterpret the codecov numbers?

Looking into the Devel::Cover report:
https://77444-20883829-gh.circle-artifacts.com/0/cover_db/t-full-stack-t.html

There it shows which lines are uncovered. I don't see these lines at all in the codecov report :-/

[kalikiana]

Codecov seems to be happy now. Please only suggest further changes if you know what to change, though. I picked the line by trial-and-error.

[mergify]

This pull request is now in conflicts. Could you fix it? 🙏

[okurz]

Overall the changes look like they do what the git commit message says but I am not convinced that we should do this waiting in all the places. I work prefer if we only do it where we actually understood that we need it. So I suggest to do the replacement only where tests actually fail and if we understood the reason in each case

[mergify]

This pull request is now in conflicts. Could you fix it? 🙏

[kalikiana]

Overall the changes look like they do what the git commit message says but I am not convinced that we should do this waiting in all the places. I work prefer if we only do it where we actually understood that we need it. So I suggest to do the replacement only where tests actually fail and if we understood the reason in each case

So after suggesting to rename find_status_text you're suggesting we check differently on a case-by-case basis? I guess I will kill the function and see what happens

Edit: This mean this will block on #4293

[mergify]

This pull request is now in conflicts. Could you fix it? 🙏

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[stale]

This Pull Request has been automatically closed as it did not have any activity in the last 97 days. Thank you.