fix ticket #8800: add needle editor readonly mode #435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -83,18 +83,20 @@ | |||
| % for my $tag (@$tags) { | |||
| <label> | |||
| <input type="checkbox" name="tags" id="tag_<%= $tag %>" class="tag_checkbox" | |||
| value="<%= $tag %>"><%= $tag %> | |||
| value="<%= $tag %>" <%= 'readonly="readonly"' unless (is_operator) %> ><%= $tag %> | |||
There was a problem hiding this comment.
for checkboxes you need to use disabled too. Otherwise they are greyed out but still state can be changed.
asdil12
force-pushed
the
needle_editor_readonly_mode
branch
from
b261027
to
870f862
Compare
|
The new patch doesn't disable the radio buttons in the Image column as their operation doesn't change the json. |
aaannz
pushed a commit
that referenced
this pull request
Oct 2, 2015
fix ticket #8800: add needle editor readonly mode
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix https://progress.opensuse.org/issues/8800