Give default value for uninitialized response code #4452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Martchus
reviewed
Jan 17, 2022
lib/OpenQA/CLI/api.pm
Outdated
Comment on lines
56
to
57
| my $res_code = $tx->res->code; | ||
| $res_code //= 0; |
There was a problem hiding this comment.
Suggested change
| my $res_code = $tx->res->code; | |
| $res_code //= 0; | |
| my $res_code = $tx->res->code // 0; |
Codecov Report
@@ Coverage Diff @@
## master #4452 +/- ##
=======================================
Coverage 97.95% 97.95%
=======================================
Files 374 374
Lines 34006 34006
=======================================
Hits 33312 33312
Misses 694 694
Continue to review full report at Codecov.
|
progress.opensuse.org/issues/104836
okurz
approved these changes
Jan 17, 2022
Martchus
approved these changes
Jan 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
res_code isn't initialized if no openQA server is running.
It now defaults to 0 if there is no connection, the "Connection refused" message still appears.
https://progress.opensuse.org/issues/104836