Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rendering HTML elements when updating unique flash messages #4454

Merged
merged 2 commits into from
Jan 17, 2022

Conversation

Martchus
Copy link
Contributor

This especially concerns the flash messages shown within the developer
mode panel, see https://progress.opensuse.org/issues/104917.

assets/javascripts/openqa.js Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jan 17, 2022

Codecov Report

Merging #4454 (e85d172) into master (c3ccca1) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4454   +/-   ##
=======================================
  Coverage   97.95%   97.95%           
=======================================
  Files         374      374           
  Lines       34016    34019    +3     
=======================================
+ Hits        33322    33325    +3     
  Misses        694      694           
Impacted Files Coverage Δ
t/ui/25-developer_mode.t 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c3ccca1...e85d172. Read the comment docs.

This especially concerns the flash messages shown within the developer
mode panel, see https://progress.opensuse.org/issues/104917.
Copy link
Member

@kraih kraih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Creative solution with makeFlashElement, i like it. 😁

@mergify mergify bot merged commit c1844f1 into os-autoinst:master Jan 17, 2022
@Martchus Martchus deleted the fix-flash branch January 17, 2022 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants