Fix reruns of full stack tests on specified temp dir #4524
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
perlpunk
approved these changes
Feb 23, 2022
kalikiana
approved these changes
Feb 23, 2022
perlpunk
requested changes
Feb 23, 2022
perlpunk
reviewed
Feb 23, 2022
| sub setup_fullstack_temp_dir { | ||
| my ($test_name) = @_; | ||
| my $tempdir = $ENV{OPENQA_FULLSTACK_TEMP_DIR} ? path($ENV{OPENQA_FULLSTACK_TEMP_DIR}) : tempdir; | ||
| my $tempdir = _test_dir(); | ||
| my $basedir = $tempdir->child($test_name); |
There was a problem hiding this comment.
This $basedir is the directory which should be deleted.
e.g. full-stack.d is doing:
my $tempdir = setup_fullstack_temp_dir('full-stack.d');
so it would be $OPENQA_FULLSTACK_TEMP_DIR/full-stack.d
Otherwise it could delete a previous dir from another test.
Codecov Report
@@ Coverage Diff @@
## master #4524 +/- ##
==========================================
- Coverage 97.96% 97.96% -0.01%
==========================================
Files 374 374
Lines 34063 34067 +4
==========================================
+ Hits 33371 33373 +2
- Misses 692 694 +2
Continue to review full report at Codecov.
|
|
See #4527 |
|
awesome, yours looks good |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.