Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cache service coverage for Minion tasks #4532

Closed
wants to merge 1 commit into from
Closed

Conversation

kraih
Copy link
Member

@kraih kraih commented Feb 25, 2022

#4526 showed that coverage is not collected correctly for Minion tasks.

@kraih kraih force-pushed the k/cache_coverage branch 2 times, most recently from e009526 to 355fedf Compare February 25, 2022 12:56
@codecov
Copy link

codecov bot commented Feb 25, 2022

Codecov Report

Merging #4532 (43127a4) into master (4c3e524) will increase coverage by 0.00%.
The diff coverage is 94.11%.

❗ Current head 43127a4 differs from pull request most recent head fb7ce43. Consider uploading reports for the commit fb7ce43 to get more accurate results

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4532   +/-   ##
=======================================
  Coverage   97.97%   97.97%           
=======================================
  Files         374      375    +1     
  Lines       34108    34126   +18     
=======================================
+ Hits        33416    33435   +19     
+ Misses        692      691    -1     
Impacted Files Coverage Δ
t/lib/OpenQA/Test/Utils.pm 83.76% <88.88%> (+1.49%) ⬆️
lib/OpenQA/CacheService.pm 100.00% <100.00%> (ø)
script/openqa-workercache 100.00% <100.00%> (ø)
lib/OpenQA/CacheService/Command/run.pm 66.66% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c3e524...fb7ce43. Read the comment docs.

@kraih kraih force-pushed the k/cache_coverage branch 3 times, most recently from 43127a4 to 968b7ed Compare February 25, 2022 14:03
t/lib/OpenQA/Test/Utils.pm Outdated Show resolved Hide resolved
@kraih
Copy link
Member Author

kraih commented Feb 25, 2022

Even after a few iterations, it does not look like the change had the effect i was hoping for. Back to the drawing board i guess.

@kraih kraih closed this Feb 25, 2022
@kraih
Copy link
Member Author

kraih commented Feb 25, 2022

I know the current code is wrong, but i can't prove it with tests yet.

@kraih kraih deleted the k/cache_coverage branch May 16, 2022 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants