Ensure consistent cancellation of chained dependent jobs #4590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4590 +/- ##
=======================================
Coverage 97.98% 97.98%
=======================================
Files 375 375
Lines 34415 34419 +4
=======================================
+ Hits 33723 33727 +4
Misses 692 692
Continue to review full report at Codecov.
|
okurz
approved these changes
Apr 1, 2022
|
According to the dictionary "dependent" is the most common form: https://www.oxfordlearnersdictionaries.com/definition/american_english/dependent_1 |
* Cancel regularly and directly chained dependencies consistently only down
the chain
* Keep the behavior for parallel dependencies as-is (so they are still
canceled up the hierarchy except PARALLEL_CANCEL_WHOLE_CLUSTER is set
to a falsy value)
* Cancellation of the entire chain at once is still possible by
canceling from the root (unless there are multiple roots)
* The cancellation up the chain was already prevented before in certain
cases but whether it worked dependent on the internal order in which
dependencies have been traversed
* Be more in-line with user expectations, at least judging by
https://progress.opensuse.org/issues/108476 it expected that
cancellation only affects jobs down the chain
* Track whether the job cluster is computed for cancellation on all levels
of nested functions calls to ensure a consistent behavior regardless of
the internal order of dependency traversal
okurz
changed the title
kalikiana
approved these changes
Apr 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the chain
canceled up the hierarchy except PARALLEL_CANCEL_WHOLE_CLUSTER is set
to a falsy value)
canceling from the root (unless there are multiple roots)
cases but whether it worked depended on the internal order in which
dependencies have been traversed
https://progress.opensuse.org/issues/108476 it expected that
cancellation only affects jobs down the chain
of nested functions calls to ensure a consistent behavior regardless of
the internal order of dependency traversal
No tests yet because I hope failing unit tests will give me a hint were to make adjustments.