Use OpenQA::Test::PatchDeparse from os-autoinst-common #4613
Conversation
perlpunk
changed the title
Codecov Report
@@ Coverage Diff @@
## master #4613 +/- ##
==========================================
+ Coverage 97.99% 98.04% +0.04%
==========================================
Files 375 374 -1
Lines 34433 34414 -19
==========================================
- Hits 33743 33740 -3
+ Misses 690 674 -16
Continue to review full report at Codecov.
|
perlpunk
force-pushed
the
patch-deparse
branch
2 times, most recently
from
183475b
to
6191001
Compare
|
I restricted tidy to t/, lib/ and script/ |
.tidyallrc
Outdated
| @@ -2,5 +2,5 @@ | |||
| ; Notice that this does include also non-Perl files in script/ so it is | |||
| ; suggested to use tools/tidy to cover all appropriate files. "tidyall -a" | |||
| ; will try to cover too much and fail on the non-Perl files | |||
| select = **/*.{pl,pm,t} script/* | |||
| select = {lib,t}/**/*.{pl,pm,t} script/* | |||
There was a problem hiding this comment.
This would exclude tools/ at least. I suggest to use
| select = {lib,t}/**/*.{pl,pm,t} script/* | |
| ignore = external/ |
There was a problem hiding this comment.
Currently ./tools/tidy -l does not list anything in tools, but ok.
But I'm a fan of explicitly including things. I hate that I have to use ignore in os-autoinst. So I will include tools explicitly.
There was a problem hiding this comment.
Well, I prefer to include everything and only exclude so that any new files or directories are not silently ignored by mistake. Having too many files included produces quite explicit errors.
There was a problem hiding this comment.
So one against one. Any other opinions?
There was a problem hiding this comment.
How many new directories in the root directory containing perl files are we expecting in the future?
There was a problem hiding this comment.
That's the point, I don't know. To be safe I suggest to include all and specify the exceptions
There was a problem hiding this comment.
There are some standard directories where perl files live in a project, and then maybe some custom ones. This config file can serve as an easy way to document in which directories we expect perl files that we want to tidy.
I don't get the argument of "being safe", especially when talking about perltidy.
There was a problem hiding this comment.
Just convince someone else of the team to vote for the "ignore" option and I'll do it =)
|
Regarding the build-docs failure https://app.circleci.com/pipelines/github/os-autoinst/openQA/9420/workflows/fe97dc24-9382-4abf-b9f9-e1adfdc4a66b/jobs/88871 I created https://progress.opensuse.org/issues/110181 |
subrepo: subdir: "external/os-autoinst-common" merged: "120b41ada" upstream: origin: "git@github.com:os-autoinst/os-autoinst-common.git" branch: "master" commit: "3de570d96" git-subrepo: version: "0.4.3" origin: "???" commit: "???"
We don'y want to tidy the external/ directory, and also not dbicdh/ I guesss.
|
I will merge this now because the webui-docker-compose failed because of a zypper timeout (ran longer than 1 hour!) |
No description provided.