Deal with unknown git revision #4633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TEST_GIT_HASH or NEEDLES_GIT_HASH might contain UNKNOWN. To avoid error messages in the log, check and return early. I moved the git_log_diff mocking to the subtests because it was global and in my new test I actually did *not* want to mock that method. Issue: https://progress.opensuse.org/issues/110389
Codecov Report
@@ Coverage Diff @@
## master #4633 +/- ##
=======================================
Coverage 98.04% 98.05%
=======================================
Files 374 374
Lines 34425 34440 +15
=======================================
+ Hits 33751 33769 +18
+ Misses 674 671 -3
Continue to review full report at Codecov.
|
okurz
approved these changes
May 2, 2022
Martchus
approved these changes
May 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TEST_GIT_HASH or NEEDLES_GIT_HASH might contain UNKNOWN.
To avoid error messages in the log, check and return early.
I moved the git_log_diff mocking to the subtests because it was global and
in my new test I actually did not want to mock that method.
Issue: https://progress.opensuse.org/issues/110389