-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow specifying NEEDLES_DIR
to be relative to CASEDIR
#4851
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4851 +/- ##
=======================================
Coverage 98.12% 98.12%
=======================================
Files 378 378
Lines 34985 34985
=======================================
Hits 34329 34329
Misses 656 656
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Documentation please. Maybe mention in the os-autoinst backend_vars as well
Great PR! Please pay attention to the following items before merging: Files matching
This is an automatically generated QA checklist based on modified files |
I hesitated to word the concluding sentence like that when I was trying to come up with something, because e.g. the |
* Allows prepending `%CASEDIR%` to relative `NEEDLES_DIR` so `%CASEDIR%` is replaced with the path where the custom `CASEDIR` will be checked out * Enables use-case of specifying a custom `CASEDIR` and a custom `NEEDLES_DIR` where the custom needles dir is a relative path within the custom `CASEDIR` (and *not* a separate repository or a relative path within the default needles directory). * See https://progress.opensuse.org/issues/117133 * See os-autoinst#4576
* Use more consistent casing * Fix typo
You're right. I replaced the "master" part with "…". |
%CASEDIR%
to relativeNEEDLES_DIR
so%CASEDIR%
is replaced with the path where the customCASEDIR
will be checked outCASEDIR
and a customNEEDLES_DIR
where the custom needles dir is a relative path within the customCASEDIR
(and not a separate repository or a relative path within the default needles directory).