Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow specifying NEEDLES_DIR to be relative to CASEDIR #4851

Merged
merged 3 commits into from
Oct 26, 2022

Conversation

Martchus
Copy link
Contributor

@codecov
Copy link

codecov bot commented Oct 19, 2022

Codecov Report

Merging #4851 (cc1ec95) into master (2dda009) will not change coverage.
The diff coverage is 100.00%.

❗ Current head cc1ec95 differs from pull request most recent head 12f10ef. Consider uploading reports for the commit 12f10ef to get more accurate results

@@           Coverage Diff           @@
##           master    #4851   +/-   ##
=======================================
  Coverage   98.12%   98.12%           
=======================================
  Files         378      378           
  Lines       34985    34985           
=======================================
  Hits        34329    34329           
  Misses        656      656           
Impacted Files Coverage Δ
lib/OpenQA/Worker/Engines/isotovideo.pm 97.22% <100.00%> (+0.05%) ⬆️
t/24-worker-engine.t 100.00% <100.00%> (ø)
t/14-grutasks.t 100.00% <0.00%> (ø)
lib/OpenQA/CacheService/Client.pm 100.00% <0.00%> (ø)
t/ui/16-tests_job_next_previous.t 100.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@okurz okurz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Documentation please. Maybe mention in the os-autoinst backend_vars as well

@github-actions
Copy link

github-actions bot commented Oct 24, 2022

Great PR! Please pay attention to the following items before merging:

Files matching docs/*.asciidoc:

  • Consider generating documentation locally to verify it is rendered correctly using tools/generate-htmldoc

This is an automatically generated QA checklist based on modified files

@phil-hands
Copy link
Contributor

I hesitated to word the concluding sentence like that when I was trying to come up with something, because e.g. the /master/ bit of that URL isn't definitely correct under all circumstances, but other than that I think that's great, and if you are OK with being mostly right-ish rather than absolutely correct, that's fine with me too :-)

* Allows prepending `%CASEDIR%` to relative `NEEDLES_DIR` so `%CASEDIR%` is
  replaced with the path where the custom `CASEDIR` will be checked out
* Enables use-case of specifying a custom `CASEDIR` and a custom
  `NEEDLES_DIR` where the custom needles dir is a relative path within the
  custom `CASEDIR` (and *not* a separate repository or a relative path
  within the default needles directory).
* See https://progress.opensuse.org/issues/117133
* See os-autoinst#4576
@Martchus
Copy link
Contributor Author

You're right. I replaced the "master" part with "…".

@mergify mergify bot merged commit 3e0fb21 into os-autoinst:master Oct 26, 2022
@Martchus Martchus deleted the needles_dir branch October 26, 2022 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants