Add button to insert marker for unblocking incident to OSD branding #4867
Conversation
|
For everyone too lazy to checkout the branch locally: Making the help popover extendable (for more help text) would likely be a bit hacky. |
Sure. I am just afraid that the text "Add marker to unblock incident" won't be enough for some users to understand that. Maybe just extend that line a bit. I know that providing a link would be tricky because people can't click on the hovering text. |
Martchus
force-pushed
the
custom-commenting-tools
branch
from
5c79ecd
to
c6c4b22
Compare
|
Extended the tooltip a little bit. |
|
Do we not have test coverage for those buttons yet? |
|
For the buttons in general, yes. (But not for all of them as they're just using the same JS function anyways.) |
| @@ -0,0 +1,5 @@ | |||
| % if (!$group_comment && !$job->is_ok) { | |||
| <a class="help_popover fa fa-unlink" title="Add marker so the specified maintenance incident will be approved despite this job" | |||
There was a problem hiding this comment.
The comment is not really correct because if other tests still fail the maintenance incident won't be approved but fine for now
There was a problem hiding this comment.
I thought the "despite this job" would be sufficient.
commit 0e5d897 Merge: b8fb43f c6c4b22 Author: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> AuthorDate: Wed Oct 26 19:18:09 2022 +0000 Commit: GitHub <noreply@github.com> CommitDate: Wed Oct 26 19:18:09 2022 +0000 Merge pull request os-autoinst#4867 from Martchus/custom-commenting-tools Add button to insert marker for unblocking incident to OSD branding
Learning from https://progress.opensuse.org/issues/119467 it turns out we should have been a bit more persistent regarding test coverage ;) |
Related ticket: https://progress.opensuse.org/issues/107923