New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
114421 add limits unit tests and implementation #4887
114421 add limits unit tests and implementation #4887
Conversation
This pull request is now in conflicts. Could you fix it? 🙏 |
Look at the list of commits. Some are definitely unrelated. Try rebasing on master skipping all unrelated commits. |
be63fde
to
b054c4e
Compare
9414933
to
89a736a
Compare
00f8384
to
b7c9590
Compare
Codecov Report
@@ Coverage Diff @@
## master #4887 +/- ##
========================================
Coverage 98.13% 98.13%
========================================
Files 378 378
Lines 35029 35171 +142
========================================
+ Hits 34374 34516 +142
Misses 655 655
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks very nice. Just a couple smaller comments.
b7c9590
to
dc4ccb5
Compare
dc4ccb5
to
7fa44ba
Compare
7fa44ba
to
b9ade4c
Compare
b9ade4c
to
fad9aad
Compare
Detected fallout while testing new Tumbleweed snapshot: https://progress.opensuse.org/issues/120315 |
we will work on this urgently |
These changes add generic default and maximum values. unit tests, as well as the implementation for limiting various routes:
see: https://progress.opensuse.org/issues/114421