Add distinct set of limits for assets #4896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
perlpunk
approved these changes
Nov 11, 2022
The generic default limit (that was taken from the "All tests" page for jobs) doesn't make any sense here so this change allows us to configure the limit for asset queries separately. Related ticket: https://progress.opensuse.org/issues/120315
|
I've been increasing the defaults as this can apparently handle a large set of results in reasonable time, tested with OSD where we currently have the biggest number of assets. (The query for assets is rather simple compared to e.g. jobs.) |
Codecov Report
@@ Coverage Diff @@
## master #4896 +/- ##
=======================================
Coverage 98.14% 98.14%
=======================================
Files 379 379
Lines 35233 35233
=======================================
Hits 34581 34581
Misses 652 652
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
okurz
approved these changes
Nov 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The generic default limit (that was taken from the "All tests" page for jobs) doesn't make any sense here so this change allows us to configure the limit for asset queries separately.
Related ticket: https://progress.opensuse.org/issues/120315