Auto-detect WORKER_HOSTNAME on worker startup if not set explicitly
#4900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Make it unnecessary to specify `WORKER_HOSTNAME` in `workers.ini` if `hostname --fqdn` returns the expected name. * Tested the used functions of the `Net::Domain` module on multiple production worker hosts (using Leap 15.3 and 15.4). They behave as expected (so workers will still register using the short hostname and `WORKER_HOSTNAME` will be set to `hostname --fqdn`). * Required on worker level for the developer mode (independently of how the variable is handled by os-autoinst) * See https://progress.opensuse.org/issues/120261#note-8
Codecov Report
@@ Coverage Diff @@
## master #4900 +/- ##
=======================================
Coverage 98.14% 98.14%
=======================================
Files 379 379
Lines 35233 35233
=======================================
Hits 34581 34581
Misses 652 652
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
okurz
added a commit
to okurz/os-autoinst
that referenced
this pull request
Nov 15, 2022
Compare to os-autoinst/openQA#4900 Related progress issue: https://progress.opensuse.org/issues/120261
okurz
approved these changes
Nov 15, 2022
|
I can do that. Of course it will only be worthwhile when also removing |
|
I have removed Judging by the worker logs it already looks good. |
perlpunk
approved these changes
Nov 15, 2022
|
Could it be that this causes this problem? https://progress.opensuse.org/issues/120579 |
os-autoinst-bot
pushed a commit
to os-autoinst-bot/openQA
that referenced
this pull request
Nov 16, 2022
commit 72a731b Merge: 8f456e6 79ab25d Author: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> AuthorDate: Tue Nov 15 16:33:20 2022 +0000 Commit: GitHub <noreply@github.com> CommitDate: Tue Nov 15 16:33:20 2022 +0000 Merge pull request os-autoinst#4900 from Martchus/worker-hostname-dedection Auto-detect `WORKER_HOSTNAME` on worker startup if not set explicitly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WORKER_HOSTNAMEinworkers.iniifhostname --fqdnreturns the expected name.Net::Domainmodule on multiple production worker hosts (using Leap 15.3 and 15.4). They behave as expected (so workers will still register using the short hostname andWORKER_HOSTNAMEwill be set tohostname --fqdn).