Add pagination for GET /api/v1/jobs #4979
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It would still make sense to extend the commit message a little bit. Otherwise it LGTM. |
Editing someone else's commit feels weird. Not sure what the polite thing to do is here. 😬 |
Codecov Report
@@ Coverage Diff @@
## master #4979 +/- ##
==========================================
- Coverage 98.17% 98.17% -0.01%
==========================================
Files 379 379
Lines 35430 35456 +26
==========================================
+ Hits 34785 34809 +24
- Misses 645 647 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
perlpunk
reviewed
Jan 10, 2023
Similar pagination implementation to `/api/v1/bugs`. Progress: https://progress.opensuse.org/issues/121102
kraih
force-pushed
the
jobs_pagination
branch
from
8caae72
to
1aa0a2a
Compare
|
Ok, commit message updated. |
kraih
force-pushed
the
jobs_pagination
branch
from
1aa0a2a
to
fb1ffb6
Compare
okurz
previously requested changes
Jan 10, 2023
kraih
force-pushed
the
jobs_pagination
branch
from
fb1ffb6
to
30b0222
Compare
okurz
approved these changes
Jan 10, 2023
perlpunk
approved these changes
Jan 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleaned up version of #4964.
Progress: https://progress.opensuse.org/issues/121102