Render bugrefs as clickable links within labels #4998
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So one does not need to add a bugref just for the sake of having a clickable link. This is especially useful as having a label and a bugref in one comment has caveats. In particular, a `force_result` will not be evaluated if the comment is carried over and the carry over itself prevents hook scripts from running. With this, the change os-autoinst/scripts#155 could be reverted. Related ticket/note: https://progress.opensuse.org/issues/124029#note-4
Codecov Report
@@ Coverage Diff @@
## master #4998 +/- ##
=======================================
Coverage 98.17% 98.17%
=======================================
Files 379 379
Lines 35482 35489 +7
=======================================
+ Hits 34836 34843 +7
Misses 646 646
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
kalikiana
approved these changes
Feb 14, 2023
perlpunk
approved these changes
Feb 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So one does not need to add a bugref just for the sake of having a
clickable link. This is especially useful as having a label and a bugref
in one comment has caveats. In particular, a
force_resultwill not beevaluated if the comment is carried over and the carry over itself prevents
hook scripts from running.
With this, the change os-autoinst/scripts#155 could
be reverted.
Related ticket/note: https://progress.opensuse.org/issues/124029#note-4