Make --skip-deps and --skip-chained-deps work as described in the docs #5026
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The documentation says that `--skip-deps` and `--skip-chained-deps` only affects parent jobs. But in the code both flags were applied unconditionally to all dependencies, no matter if `--clone-children` was present as well. With this patch applied you can use `--skip-deps --clone-children` to clone a job with its children, but without parents. The documentation was added 7 years ago, together with the dependency cloning feature, which at the time only allowed parents to be cloned. 4 years later another feature was introduced that allows for child jobs to be cloned as well. Here it appears the old documentation was missed, and has been incorrect since then. Clone dependencies: 39cbc40 Clone children: 7cb28ed Progress: https://progress.opensuse.org/issues/124493
mimi1vx
approved these changes
Mar 3, 2023
baierjan
approved these changes
Mar 3, 2023
Martchus
approved these changes
Mar 3, 2023
Codecov Report
@@ Coverage Diff @@
## master #5026 +/- ##
=======================================
Coverage 98.19% 98.19%
=======================================
Files 379 379
Lines 35570 35592 +22
=======================================
+ Hits 34929 34951 +22
Misses 641 641
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The documentation says that
--skip-depsand--skip-chained-depsonly affects parent jobs. But in the code both flags were applied unconditionally to all dependencies, no matter if--clone-childrenwas present as well.With this patch applied you can use
--skip-deps --clone-childrento clone a job with its children, but without parents.The documentation was added 7 years ago, together with the dependency cloning feature, which at the time only allowed parents to be cloned. 4 years later another feature was introduced that allows for child jobs to be cloned as well. Here it appears the old documentation was missed, and has been incorrect since then.
Clone dependencies: 39cbc40
Clone children: 7cb28ed
Progress: https://progress.opensuse.org/issues/124493