-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't rely on js for badge length setting #5045
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I generally like the lookup-table approach. Seems much simpler/faster than your previous if-else-cascade attempt.
By the way, how did you come up with these scaling factors? Maybe it is worth adding a comment?
The lookup table was created using the HTML testpage (see https://progress.opensuse.org/issues/124173#note-12) which looks like #5045 (comment). openQA/lib/OpenQA/WebAPI/Controller/Test.pm Lines 42 to 44 in 3f9cca7
|
JS doesn't work when SVG is shown via <img> tag. Ticket: https://progress.opensuse.org/issues/124173
Codecov Report
@@ Coverage Diff @@
## master #5045 +/- ##
=======================================
Coverage 98.23% 98.23%
=======================================
Files 381 381
Lines 35870 35876 +6
=======================================
+ Hits 35238 35244 +6
Misses 632 632
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
JS doesn't work when SVG is shown via
tag.
Ticket: https://progress.opensuse.org/issues/124173