Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid live view getting stuck in a certain case #5058

Merged
merged 1 commit into from Mar 27, 2023

Conversation

Martchus
Copy link
Contributor

If the to be appended part of the received log content does not contain a newline, the code for discarding the first probably partial line can get stuck in an endless loop. This change fixes the loop condition to avoid this.

If the to be appended part of the received log content does not
contain a newline, the code for discarding the first probably
partial line can get stuck in an endless loop. This change fixes
the loop condition to avoid this.
Copy link
Member

@okurz okurz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would you like to hot-patch that on o3 to test?

@Martchus
Copy link
Contributor Author

Martchus commented Mar 27, 2023

Why not One needed to copy the packages from the CI check manually to the host because there's no publishing/repository. So likely not worth the effort.

@mergify mergify bot merged commit a546175 into os-autoinst:master Mar 27, 2023
36 checks passed
@Martchus Martchus deleted the avoid-endless-loop branch March 28, 2023 10:15
@okurz
Copy link
Member

okurz commented Mar 30, 2023

Why not One needed to copy the packages from the CI check manually to the host because there's no publishing/repository. So likely not worth the effort.

You can simply enable the publishing flag on the automatically generated OBS repositories and then either add the repo or download the RPM packages from there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants