openqa-clone-job: Apply group settings to all cloned jobs #5066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change makes `_GROUP` and `_GROUP_ID` "global" settings so one can clone a set of jobs into another group or no group via, e.g. `openqa-clone-job $some_url _GROUP=0`. Otherwise one needed to take dependencies into account and possibly specify `--parental-inheritance` (which would then apply all settings to the parent which might not be wanted as well). The downside is that leaving the parent jobs that are cloned as well in their job groups is not possible anymore. However, I don't think that this is a realy use case of our users anyways.
Martchus
force-pushed
the
global-clone-settings
branch
from
6ef2173
to
93cae45
Compare
Martchus
changed the title
Codecov Report
@@ Coverage Diff @@
## master #5066 +/- ##
=======================================
Coverage 98.25% 98.25%
=======================================
Files 383 383
Lines 36026 36026
=======================================
Hits 35396 35396
Misses 630 630
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
mimi1vx
approved these changes
Apr 12, 2023
kalikiana
approved these changes
Apr 13, 2023
os-autoinst-bot
pushed a commit
to os-autoinst-bot/openQA
that referenced
this pull request
Apr 14, 2023
commit d0e672c Merge: a3baeed 93cae45 Author: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> AuthorDate: Thu Apr 13 08:40:45 2023 +0000 Commit: GitHub <noreply@github.com> CommitDate: Thu Apr 13 08:40:45 2023 +0000 Merge pull request os-autoinst#5066 from Martchus/global-clone-settings openqa-clone-job: Apply group settings to all cloned jobs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes
_GROUPand_GROUP_ID"global" settings so one can clone a set of jobs into another group or no group via, e.g.openqa-clone-job $some_url _GROUP=0. Otherwise one needed to take dependencies into account and possibly specify--parental-inheritance(which would then apply all settings to the parent which might not be wanted as well).The downside is that leaving the parent jobs that are cloned as well in their job groups is not possible anymore. However, I don't think that this is a realy use case of our users anyways.