Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve out-of-the-box experience when invoking web UI container #5075

Merged
merged 3 commits into from Apr 13, 2023

Conversation

Martchus
Copy link
Contributor

The copy commands for the Apache config can be merged.
* Configure a default certificate in the container startup
  script (as a fallback)
* Start and configure the database inside the container unless
  the database has been configured by the user manually
* Improve documentation
* See https://progress.opensuse.org/issues/127091
* See https://progress.opensuse.org/issues/127139
@github-actions
Copy link

Great PR! Please pay attention to the following items before merging:

Files matching docs/*.asciidoc:

  • Consider generating documentation locally to verify it is rendered correctly using tools/generate-htmldoc

This is an automatically generated QA checklist based on modified files.

@Martchus
Copy link
Contributor Author

Note that I've simply tested this by building the container image locally via podman image build --tag openqa_webui_local_build . and then using openqa_webui_local_build:latest instead of registry.opensuse.org/devel/openqa/containers15.4/openqa_webui:latest.

We have tests for the docker-compose setup which shouldn't be impacted by this.

I'm still getting the error Can not create MOJO_TMPDIR : mkdir /var/lib/openqa/share/factory: File exists at /usr/share/openqa/script/../lib/OpenQA/Setup.pm line 337. which I'm going to look into but this error was there before and shouldn't prevent use to merge this.

Copy link
Member

@kalikiana kalikiana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. I can confirm that it works now.

@Martchus
Copy link
Contributor Author

Looks like codecov hasn't run at all. Since I'm not changing any Perl code anyways I'm just merging the PR manually.

@Martchus Martchus merged commit a3baeed into os-autoinst:master Apr 13, 2023
33 checks passed
@Martchus Martchus deleted the container branch April 13, 2023 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants