Highlight available test result comments on overview #514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
okurz
force-pushed
the
feature/label
branch
3 times, most recently
from
9740792
to
8c9ac90
Compare
| @@ -533,6 +533,8 @@ table.overview .failedmodule { | |||
| .fa.result_incomplete { color: #AF1E11;} | |||
| .fa.module_none { color:#bebebe;} | |||
|
|
|||
| .comment { color: Grey; } | |||
There was a problem hiding this comment.
I think you want the selector more specific - or the class name itself. comments can be anywhere anything - but you're only meaning the one icon on the overview page.
okurz
changed the title
okurz
changed the title
|
updated:
@coolo I did not do "prefetch" as I don't know what this would actually do in this context or how I should do it and also I did not test with a production database dump as I forgot the link you gave me with a dump. |
| @@ -139,6 +139,14 @@ | |||
| </span> | |||
| % } | |||
| % } | |||
| % if ($res->{comments} && $res->{comments} > 0) { | |||
There was a problem hiding this comment.
no, but if it would be, I better not try to dereference the comments.
|
updated:
|
|
+waitfor should the comments bubble always be shown or only when selected with a query parameter? |
|
as job comments are very rare, I'm fine with them being always there in case |
The availability of comments on the test result page is shown on the test result overview page next to the status icon and failed modules if available. The icon only appears if comments are available. This way it should be much easier for reviewers of test runs to exchange and see if an issue has already been noticed by someone else. Be aware that so far the comments are per test result not per test case or scenario. Related issue: https://progress.opensuse.org/issues/10212
Prefetch the job comments instead of relying on custom query.
|
aww, I messed up, wait for update. Please don't look |
Also remembers tab on reload of URLs with hash.
|
updated:
|
okurz
changed the title
coolo
added a commit
that referenced
this pull request
Feb 11, 2016
Highlight available test result comments on overview
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The availability of comments on the test result page is shown on the test
result overview page next to the status icon and failed modules if available and if selected with the corresponding query parameter "show_comment=1".
The icon only appears if comments are available. This way it should be much
easier for reviewers of test runs to exchange and see if an issue has already
been noticed by someone else.
Be aware that so far the comments are per test result not per test case or
scenario.
Related issue: https://progress.opensuse.org/issues/10212
see screenshot for example with hover info:
