Consider a tag's version when cleaning up job results #5146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5146 +/- ##
=======================================
Coverage 98.27% 98.27%
=======================================
Files 388 388
Lines 36712 36730 +18
=======================================
+ Hits 36080 36098 +18
Misses 632 632
|
Martchus
force-pushed
the
build-tagging
branch
2 times, most recently
from
0e976b1
to
1b9dfb3
Compare
kalikiana
reviewed
May 19, 2023
|
This pull request is now in conflicts. Could you fix it? 🙏 |
kalikiana
approved these changes
May 22, 2023
|
@Mergifyio rebase |
❌ Base branch update has failedGit reported the following error: err-code: 6049E |
When cleaning up job results, jobs being part of an important build are treated differently. So far really only the BUILD variable is used to decide whether a job belongs to an important build - even if the according tag includes a version number. With this change the version from the tag is considered as well and matched against the job's VERSION variable. When a tag only specifies the BUILD then it is still just matched against the job's BUILD variable. Related ticket/note: https://progress.opensuse.org/issues/129244#note-18
okurz
reviewed
May 23, 2023
baierjan
approved these changes
May 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When cleaning up job results, jobs being part of an important build are treated differently. So far really only the BUILD variable is used to decide whether a job belongs to an important build - even if the according tag includes a version number.
With this change the version from the tag is considered as well and matched against the job's VERSION variable.
Related ticket/note: https://progress.opensuse.org/issues/129244#note-18