New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not hardlink symlink assets #5220
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5220 +/- ##
=======================================
Coverage 98.30% 98.31%
=======================================
Files 389 389
Lines 37113 37123 +10
=======================================
+ Hits 36484 36496 +12
+ Misses 629 627 -2
|
I'm getting a weird failure on circleci:
However, the test is passing locally. Not sure what's going on there... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks generally good.
Ah, nevermind, I forgot to commit a new file... should be fixed |
Issue: https://progress.opensuse.org/issues/129340 Hardlinking a symlink will only work if the link is absolute, and we would have to check that recursively if the symlink target itself is a symlink, so just fall back to symlink then.
Issue: https://progress.opensuse.org/issues/129340
Hardlinking a symlink will only work if the link is absolute, and we would have to check that recursively if the symlink target itself is a symlink, so just fall back to symlink then.