Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not hardlink symlink assets #5220

Merged
merged 1 commit into from Jun 23, 2023
Merged

Conversation

perlpunk
Copy link
Contributor

@perlpunk perlpunk commented Jun 23, 2023

Issue: https://progress.opensuse.org/issues/129340

Hardlinking a symlink will only work if the link is absolute, and we would have to check that recursively if the symlink target itself is a symlink, so just fall back to symlink then.

@codecov
Copy link

codecov bot commented Jun 23, 2023

Codecov Report

Merging #5220 (c096125) into master (8d9fc92) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head c096125 differs from pull request most recent head 2cde027. Consider uploading reports for the commit 2cde027 to get more accurate results

@@           Coverage Diff           @@
##           master    #5220   +/-   ##
=======================================
  Coverage   98.30%   98.31%           
=======================================
  Files         389      389           
  Lines       37113    37123   +10     
=======================================
+ Hits        36484    36496   +12     
+ Misses        629      627    -2     
Impacted Files Coverage Δ
lib/OpenQA/Worker/Engines/isotovideo.pm 97.93% <100.00%> (+0.70%) ⬆️
t/24-worker-engine.t 100.00% <100.00%> (ø)

@perlpunk
Copy link
Contributor Author

perlpunk commented Jun 23, 2023

I'm getting a weird failure on circleci:
https://app.circleci.com/pipelines/github/os-autoinst/openQA/11816/workflows/310c0f76-e852-40f1-b121-ff5829f9d4ff/jobs/110462

[11:04:31] t/24-worker-engine.t ...................................... 1/?
 Can't open file "poolAgHr/vars.json": No such file or directory at t/24-worker-engine.t line 60.
# Tests were run but no plan was declared and done_testing() was not seen.
# Looks like your test exited with 255 just after 11.
[11:04:31] t/24-worker-engine.t ......................................       Dubious, test returned 255 (wstat 65280, 0xff00)
All 11 subtests passed

However, the test is passing locally. Not sure what's going on there...

Copy link
Contributor

@Martchus Martchus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks generally good.

t/24-worker-engine.t Outdated Show resolved Hide resolved
@perlpunk
Copy link
Contributor Author

I'm getting a weird failure on circleci:

Ah, nevermind, I forgot to commit a new file... should be fixed

@perlpunk perlpunk marked this pull request as ready for review June 23, 2023 12:02
lib/OpenQA/Worker/Engines/isotovideo.pm Outdated Show resolved Hide resolved
Issue: https://progress.opensuse.org/issues/129340

Hardlinking a symlink will only work if the link is absolute, and
we would have to check that recursively if the symlink target
itself is a symlink, so just fall back to symlink then.
@perlpunk perlpunk requested a review from okurz June 23, 2023 14:44
@mergify mergify bot merged commit e11feac into os-autoinst:master Jun 23, 2023
36 checks passed
@perlpunk perlpunk deleted the symlink-assets branch June 23, 2023 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants