Allow to partially re-schedule a product from a job #5233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is possible to set required parameters to falsy values when scheduling a product, e.g. `VERSION=0`. This changes allows re-triggering such a scheduled product without running into a validation error.
* Allow to re-trigger a scheduled product from the job details
page of a job of this product
* Re-schedule the job itself and all its chained children
and parallel dependencies
* Do *not* re-schedule chained parents
* Refactor JavaScript code for re-scheduling so it can be used
on the job details page as well
* Improve error handling in JavaScript code for re-scheduling
* State successful re-triggering via "The product has been
re-triggered as …" with a link (instead of "… should appear
when refreshing page.").
* Related ticket: https://progress.opensuse.org/issues/124469
Codecov Report
@@ Coverage Diff @@
## master #5233 +/- ##
=======================================
Coverage 98.31% 98.31%
=======================================
Files 389 389
Lines 37133 37140 +7
=======================================
+ Hits 36506 36514 +8
+ Misses 627 626 -1
|
okurz
approved these changes
Jul 4, 2023
* Ask for confirmation before invoking the re-trigger * Related ticket: https://progress.opensuse.org/issues/124469
* Use a distinct icon for the reschedule button * Related ticket: https://progress.opensuse.org/issues/124469
|
Removing the not-ready label as we gave people enough time to review. There's still at least one more review required anyways. |
kalikiana
approved these changes
Jul 24, 2023
perlpunk
reviewed
Jul 25, 2023
| const id = jqXHR.responseJSON?.scheduled_product_id; | ||
| const msg = | ||
| typeof id === 'number' | ||
| ? `The product has been re-triggered as <a href="/admin/productlog?id=${id}">${id}</a>.` |
There was a problem hiding this comment.
This results in
unterminated quoted string literal at /usr/lib/perl5/vendor_perl/5.26.1/Mojolicious/Plugin/AssetPack/Pipe/JavaScript.pm line 22.
in https://build.opensuse.org/package/live_build_log/devel:openQA/openQA/openSUSE_Leap_15.4/x86_64
There was a problem hiding this comment.
I proposed #5264 to address this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(see commit message for details)
page of a job of this product
and parallel dependencies
on the job details page as well
re-triggered as …" with a link (instead of "… should appear
when refreshing page.").