Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

contrib: Extend and add autoyast profiles #5251

Merged
merged 2 commits into from Sep 4, 2023

Conversation

okurz
Copy link
Member

@okurz okurz commented Jul 19, 2023

No description provided.

@okurz okurz marked this pull request as draft July 19, 2023 09:10
In the new SUSE PRG2 datacenter we have new servers with 2x512GiB NVMe
and 1x6TiB NVMe. I think it is not feasible to combine all those with
the existing autoyast profile template so adding as separate file. The
profile also explicitly adds the "kvm_server" pattern so that a network
bridge is configured already from the start.

By the way I tried out to use the .xml.erb file supplied to the openSUSE
installer which could not parse the file. So maybe the .xml.erb profile
is meant to be processed by a server into a final xml file or a
different command than the boot line `autoyast=…` would need to be used.

Related progress issue: https://progress.opensuse.org/issues/132134
Copy link
Contributor

@Martchus Martchus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR title doesn't match the commit messages at all.

@okurz okurz changed the title Document custom rsync command examples for TESTPOOLSERVER contrib: Extend and add autoyast profiles Jul 20, 2023
@okurz
Copy link
Member Author

okurz commented Sep 4, 2023

The PR title doesn't match the commit messages at all.

It does now

@okurz okurz marked this pull request as ready for review September 4, 2023 11:51
<partitions t="list">
<partition>
<size>max</size>
<filesystem t="symbol">ext4</filesystem>
Copy link
Member

@mimi1vx mimi1vx Sep 4, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isn't this reformatted by service to ext2 ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only if we actually use that service which is AFAIK only the case in OSD with salt

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think ext4 is a good default. If it gets overridden that's not a problem.

<partitions t="list">
<partition>
<size>max</size>
<filesystem t="symbol">ext4</filesystem>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think ext4 is a good default. If it gets overridden that's not a problem.

@mergify mergify bot merged commit 3984fd5 into os-autoinst:master Sep 4, 2023
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants