-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show max running jobs on /tests page #5279
Conversation
e37b0fd
to
fc160ea
Compare
Oh wait, since this is only shown when the limit is reached I think this is redundant :) |
fc160ea
to
9fcb924
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm fine with printing just "… (limited by server config)" in case the limit is effected. Otherwise it would be rather redundant. I'd also avoid a "x / y" format unless we are really sure not to end up with e.g. "201 / 200" in production (which would look rather buggy).
9fcb924
to
f60885d
Compare
If it is always a number, it is easier to handle. Issue: https://progress.opensuse.org/issues/129619
f60885d
to
527b3e6
Compare
Codecov Report
@@ Coverage Diff @@
## master #5279 +/- ##
=======================================
Coverage 98.31% 98.31%
=======================================
Files 389 389
Lines 37184 37190 +6
=======================================
+ Hits 36558 36564 +6
Misses 626 626
|
So I investigated the problem with max_running_jobs not always being set to the default value, causing warnings. I think that's unfortunate because we have to cover for that in code by ensuring a default value in several places, although that should be done by OpenQA::Setup in just one place. I will create a ticket because I had a quick look, and it looks to me like it's not fixable very fast. |
If the limit is reached, people will see that in the header of the running jobs table. We do a COUNT because the job query can actually be limited by several parameters, not giving us the complete count. Issue: https://progress.opensuse.org/issues/129619
527b3e6
to
5707d4e
Compare
See individual commits
I think we could also show the actual limit value, e.g.x jobs are running (limited by server config: 250)
WDYT?