scheduler: Log statistics of rejected jobs #5306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
perlpunk
force-pushed
the
scheduler-logging
branch
3 times, most recently
from
f53c846
to
a3731a5
Compare
perlpunk
changed the title
kalikiana
reviewed
Sep 13, 2023
perlpunk
force-pushed
the
scheduler-logging
branch
from
a3731a5
to
4ba2876
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #5306 +/- ##
=======================================
Coverage 98.31% 98.32%
=======================================
Files 389 389
Lines 37247 37285 +38
=======================================
+ Hits 36621 36659 +38
Misses 626 626
☔ View full report in Codecov by Sentry. |
okurz
requested changes
Sep 14, 2023
perlpunk
force-pushed
the
scheduler-logging
branch
from
4ba2876
to
50dfcd3
Compare
okurz
approved these changes
Sep 14, 2023
Martchus
reviewed
Sep 15, 2023
perlpunk
force-pushed
the
scheduler-logging
branch
from
50dfcd3
to
7d78390
Compare
Martchus
approved these changes
Sep 19, 2023
Comment on lines
+57
to
+58
| $jobinfo->{matching_workers} = _matching_workers($jobinfo, $free_workers, \%rejected); | ||
| delete $scheduled_jobs->{$id} unless @{$jobinfo->{matching_workers}}; |
There was a problem hiding this comment.
Just a suggestion:
Suggested change
| $jobinfo->{matching_workers} = _matching_workers($jobinfo, $free_workers, \%rejected); | |
| delete $scheduled_jobs->{$id} unless @{$jobinfo->{matching_workers}}; | |
| my $workers = $jobinfo->{matching_workers} = _matching_workers($jobinfo, $free_workers, \%rejected); | |
| delete $scheduled_jobs->{$id} unless @$workers; |
perlpunk
force-pushed
the
scheduler-logging
branch
2 times, most recently
from
c39533c
to
8fbd0fd
Compare
We want to know how many jobs are skipped because of no available workers matching requested WORKER_CLASS settings. Related issues: * https://progress.opensuse.org/issues/135578 * https://progress.opensuse.org/issues/129619
perlpunk
force-pushed
the
scheduler-logging
branch
from
8fbd0fd
to
508ef3e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to know how many jobs are skipped because of no available workers matching requested WORKER_CLASS settings.
Related issues: