Fix key navigation on test details #5309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
By the way, I guess we have a ticket for that. However, I couldn't find it. (I came across this problem again when working on https://progress.opensuse.org/issues/136028.) |
|
This is poo#113468 I think? |
Martchus
force-pushed
the
key-handling
branch
from
10e1720
to
b7b54fb
Compare
perlpunk
approved these changes
Sep 20, 2023
okurz
approved these changes
Sep 20, 2023
|
@Mergifyio rebase |
✅ Nothing to do for rebase action |
|
@kalikiana as long as is not in rebasing won't help |
|
@Mergifyio rebase |
When viewing a test live and test module details are added to the page dynamically, then the key navigation breaks. It skips steps instead of just selecting the next/previous step. This is because the event handler is registered multiple times. This change fixes the issue by making sure the event handler is only registered once. Related ticket: https://progress.opensuse.org/issues/113468
✅ Branch has been successfully rebased |
perlpunk
force-pushed
the
key-handling
branch
from
b7b54fb
to
f1b115c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When viewing a test live and test module details are added to the page dynamically, then the key navigation breaks. It skips steps instead of just selecting the next/previous step. This is because the event handler is registered multiple times. This change fixes the issue by making sure the event handler is only registered once.