Reduce runtime of t/04-scheduler.t #5315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm now reusing jobs and also reduced the number of workers. This reduced the runtime a bit from 2.07 to 1.84. Considering that the test before only had one worker and two jobs, and that we want to test code which deals with multiple workers and jobs, I think the increase to before the original pull request is legitimate. Issue: https://progress.opensuse.org/issues/129619
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5315 +/- ##
=======================================
Coverage 98.32% 98.32%
=======================================
Files 389 389
Lines 37285 37285
=======================================
Hits 36659 36659
Misses 626 626
☔ View full report in Codecov by Sentry. |
okurz
approved these changes
Sep 27, 2023
kalikiana
approved these changes
Sep 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm now reusing jobs and also reduced the number of workers. This reduced the runtime a bit from 2.07 to 1.84.
Considering that the test before only had one worker and two jobs, and that we want to test code which deals with multiple workers and jobs, I think the increase to before the original pull request is legitimate.
Issue: https://progress.opensuse.org/issues/129619